This project is read-only.
1

Closed

Non virtual members in controller base class

description

Most of the voice controller members are not virtual. I have a case where my app is sitting behind a load balancer, and sees all requests as HTTP, even though the load balancer is serving https and I need to keep it that way.

I worked around this by hacking the Views to replace http:// with https://, but this is nasty hack.

If I could have overridden ApplicationUri i could have implemented it there instead of having to change the code in several places. (This is just one example where virtual members would have been very helpful, there are many others)
Closed Dec 21, 2013 at 5:54 PM by plaguethenet

comments

kjunghans wrote Dec 4, 2013 at 1:55 PM

Thank you for your feedback on VoiceModel. Would you please provide a list of methods you think should be virtual, besides ApplicationUri. Also, would you please provide the code you would use to override ApplicationUri to work in your environment. Are you just hard coding whether it is http or https? Is there a way we can implement this so it works in all environments?

wrote Dec 4, 2013 at 1:55 PM

plaguethenet wrote Dec 16, 2013 at 12:59 PM

(If members listed are private, they should be made protected.)

GetCallFlow
SetCallFlow
VoiceView
Recording
SaveRecording
SaveRecordingTropo
Tropo
StartTropo

Maybe the URL's as well. (So basically everything)

I was going to hard code it, there really isn't a common way to do it, each situation will be different. (EX: Some may have a header, others like us may always want HTTPS, but iis may not be aware its https, etc.)

plaguethenet wrote Dec 18, 2013 at 7:54 PM

I will work on this this weekend if I have time, Reassigned to me.

wrote Dec 21, 2013 at 5:18 PM

Associated with changeset 27867: Created branch for bug fixes and other enhancements.

wrote Dec 21, 2013 at 5:54 PM

Resolved with changeset 27869: Fixes these issues and provides more extensibiltiy. Merge to main branch when ready to accept.

wrote Nov 28 at 4:37 AM